Skip to content

ci: update ITK and ACTS to patched .NET toolchain - #606

Merged
tracyboehrer merged 1 commit into
mainfrom
users/tracyboehrer/update-itk-acts-toolchain
Nov 10, 2026
Merged

tracyboehrer merged 1 commit into
mainfrom
users/tracyboehrer/update-itk-acts-toolchain

Conversation

@tracyboehrer

@tracyboehrer tracyboehrer commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Update the ITK and ACTS PR/nightly workflow checkout refs and matching A2A_ITK_REVISION values to a39f6eb05c58aa41d4f46a758e73c2df1c3be49c.
  • Keep the local-run revision in itk/README.md consistent.
  • Pick up fix(docker): pin .NET SDK 10.0.403 and 8.0.33 runtime to resolve NU1903 a2a-itk#88, which pins .NET SDK 10.0.403 and ASP.NET Core runtime 8.0.33 and corrects the launcher's image-digest input. No SDK runtime behavior, conformance gates, or known-failure exclusions are changed.

Why

Copilot traced the failures starting on 2026-11-05 to the cached ITK image's .NET SDK 10.0.401. Publishing the test agent restores implicit Microsoft.DotNet.ILCompiler packages 10.0.12 / 8.0.31, which fail NuGet audit with NU1903 for GHSA-p3jp-9v83-76w9 because warnings are errors. The test agent never starts: ITK records all 74 scenarios as failed, while ACTS rejects its empty error response and stops refreshing the published metrics.

The upstream repair is merged, but this repository still uses the older d53108aaf378a38eaff64ea39029a3d795591827 revision. Both the checkout refs and shared-driver environment values must move together; otherwise itk/run_itk.sh checks out the older revision again.

Baseline failures: ITK and ACTS. The existing optional push-config findings and REST subscription advisory (#591) are separate and unchanged.

Validation

Copilot verified:

  • All four workflow YAML files parse, both revision pins in each workflow match the patched upstream commit, and the README uses the same revision. The check fails before the update and passes afterward.
  • git diff --check passes; the diff is limited to five files and nine line replacements.
  • Local end-to-end Docker validation is unavailable because the Docker daemon is not running. GitHub has not registered ITK/ACTS runs for this PR during the observation window, despite both workflows being active. End-to-end CI validation remains pending; no passing integration-test result is claimed.

Update all checkout and shared-driver pins to a2aproject/a2a-itk@a39f6eb,
which includes the pinned .NET SDK 10.0.403 and ASP.NET runtime 8.0.33
from a2aproject/a2a-itk#88. Keep local-run documentation in sync.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 356f5c58-aa9f-4e27-84bb-6c46949769ad

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the workflow revision and documentation updates.

No open issues 🎉

What changed in this PR

Updates the SDK’s ITK and ACTS workflows to the upstream revision containing the patched .NET toolchain and launcher image-digest fix, addressing test-agent startup failures.

Changes:

  • Aligns checkout refs and A2A_ITK_REVISION values across all four workflows to a39f6eb05c58aa41d4f46a758e73c2df1c3be49c.
  • Updates local-run documentation to use the same revision.
  • Leaves SDK runtime behavior, conformance gates, and known-failure exclusions unchanged.
File Description
itk/​README.md Aligns the documented local-run revision with CI.
.github/​workflows/​itk.yaml Updates both revision pins for PR interoperability checks.
.github/​workflows/​itk-nightly.yaml Updates both revision pins for nightly interoperability runs.
.github/​workflows/​acts.yaml Updates both revision pins for PR conformance checks.
.github/​workflows/​acts-nightly.yaml Updates both revision pins for nightly conformance runs.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

ACTS advisory results

Commit: 666f42a3f7ab | ACTS run and full reports

Non-blocking advisory: This comment is informational only and does not block merging this PR. Advisory failures may or may not be related to changes in this PR; they do not, on their own, establish a regression introduced by this PR. The MUST-only conformance gate is unchanged.

7 SHOULD/MAY failure(s) or error(s) across the tested transports.

Level Transport Test Result Reason
SHOULD rest REST-SUB-GET-001 fail the SUT answered a streaming request with content type 'application/a2a+json' instead of opening a stream
MAY grpc PUSH-CFG-002 fail expected a response body, got error TaskNotFoundError: Push configuration not found.
MAY grpc PUSH-LIST-001 fail body.configs is missing, so it cannot be of type array
MAY jsonrpc PUSH-CFG-002 fail expected a response body, got error TaskNotFoundError: Push configuration not found.
MAY jsonrpc PUSH-LIST-001 fail body.configs should have length >= 1, got []
MAY rest PUSH-CFG-002 fail expected a response body, got error TaskNotFoundError: Push configuration not found.
MAY rest PUSH-LIST-001 fail body.configs should have length >= 1, got []

@tracyboehrer
tracyboehrer added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 8d3a083 Nov 10, 2026
14 checks passed
@tracyboehrer
tracyboehrer deleted the users/tracyboehrer/update-itk-acts-toolchain branch November 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants